Updated the default partitioner to the AutoBucketPartitioner #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses the $bucketAuto aggregation stage and works for compound keys as well as single keys. SPARK-444
rozza
commented
Apr 30, 2025
...ionTest/java/com/mongodb/spark/sql/connector/read/partitioner/AutoBucketPartitionerTest.java
Show resolved
Hide resolved
rozza
requested review from
a team and
NathanQingyangXu
and removed request for
a team
|
@NathanQingyangXu no need to download the code / run locally, you can rely on evergreen. |
|
Reopened PR - as no partitioners will support duplicated compound key values, I have added a warning for users if they have an older MongoDB version. |
...ntegrationTest/java/com/mongodb/spark/sql/connector/mongodb/MongoSparkConnectorTestCase.java
Outdated
Show resolved
Hide resolved
src/main/java/com/mongodb/spark/sql/connector/read/partitioner/AutoBucketPartitioner.java
Outdated
Show resolved
Hide resolved
NathanQingyangXu
suggested changes
Apr 30, 2025
src/main/java/com/mongodb/spark/sql/connector/read/partitioner/AutoBucketPartitioner.java
Outdated
Show resolved
Hide resolved
...ionTest/java/com/mongodb/spark/sql/connector/read/partitioner/AutoBucketPartitionerTest.java
Show resolved
Hide resolved
Added new test cases. Although strangely nested compound keys work pre 7.0, its better to hard fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses the $bucketAuto aggregation stage and works for compound keys as well as single keys.
SPARK-444