Improved support for MongoOffsets using hadoop file systems #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spark expects hadoop configurations to be prefixed with `spark.hadoop`. However, documentation on the web omits this prefix when setting filesystem configuration - See the azure storage docs. The issue the connector has is the `MongoOffset` support just uses the `SparkContext.hadoopConfiguration()` helper method, which omits any non-prefixed configuration. So this improvement adds any filesystem configuration prefixed with `fs.` to the hadoop configuration. This ensures that the `MongoOffset`s use of the Hadoop filesystem includes the configuraion. SPARK-438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark expects hadoop configurations to be prefixed with
spark.hadoop. However, documentation on the web omits this prefix when setting filesystem configuration - See the azure storage docs.The issue the connector has is the
MongoOffsetsupport just uses theSparkContext.hadoopConfiguration()helper method, which omits any non-prefixed configuration. So this improvement adds any filesystem configuration prefixed withfs.to the hadoop configuration. This ensures that theMongoOffsets use of the Hadoop filesystem includes the configuraion.SPARK-438