Fix convertJson configuration parsing #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPARK-425
rozza
requested review from
a team,
jyemin and
stIncMale
and removed request for
a team
stIncMale
approved these changes
Apr 17, 2024
|
|
||
| static ConvertJson fromString(final String jsonType) { | ||
| if (jsonType.equalsIgnoreCase(TRUE)) { | ||
| static ConvertJson fromString(final String operationType) { |
There was a problem hiding this comment.
[optional]
Not that I understand how the previous name "jsonType" was a good description for a value of the convertJson option, but neither do I understand why "operationType" is a good description for that. Wouldn't operationType or even just v be more relevant?
There was a problem hiding this comment.
I just used it as its the same name in the constructor. Will update.
| WriteConfig writeConfig = MongoConfig.createConfig(CONFIG_MAP).toWriteConfig(); | ||
| assertEquals(writeConfig.convertJson(), WriteConfig.ConvertJson.FALSE); | ||
| assertEquals( | ||
| writeConfig.withOption("convertJson", "True").convertJson(), WriteConfig.ConvertJson.ANY); |
There was a problem hiding this comment.
[optional]
Let's also add
assertEquals(
writeConfig.withOption("convertJson", "False").convertJson(), WriteConfig.ConvertJson.FALSE);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARK-425