Fix handling of empty strings when parsing #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozza
requested review from
a team and
stIncMale
and removed request for
a team
stIncMale
requested changes
Apr 15, 2024
Comment on lines
277
to
280
| private static boolean isJsonObjectOrArray(@Nullable final String data) { | ||
| if (data == null || data.isEmpty()) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
data can't currently be null, so there is no need to relax the method requirements my allowing null values, which our Spark connector don't currently pass anyway.
Suggested change
| private static boolean isJsonObjectOrArray(@Nullable final String data) { | |
| if (data == null || data.isEmpty()) { | |
| return false; | |
| } | |
| private static boolean isJsonObjectOrArray(final String data) { | |
| if (data.isEmpty()) { | |
| return false; | |
| } |
There was a problem hiding this comment.
The import org.jetbrains.annotations.Nullable; line is also not needed anymore. It's surprising that the static checks don't complain about it.
I am approving to speedup the process: once the line is removed, feel free to merge.
…DocumentConverter.java Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
stIncMale
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARK-421