RUST-1417 Add support for GCP attached service accounts when using GCP KMS #877
Conversation
|
The evergreen failures should be fixed after rebasing. |
src/client/csfle/state_machine.rs
Outdated
| let host = std::env::var("GCE_METADATA_HOST") | ||
| .unwrap_or_else(|_| "metadata.google.internal".into()); | ||
| let uri = format!( | ||
| "http://{}/computeMetadata/v1/instance/service-accounts/default/token", |
There was a problem hiding this comment.
nit: looks like these lines are missing an indent
src/runtime/http.rs
Outdated
| @@ -1,17 +1,17 @@ | |||
| #[cfg(feature = "aws-auth")] | |||
| #[cfg(any(feature = "aws-auth", feature = "in-use-encryption-unstable"))] | |||
There was a problem hiding this comment.
I assume you're planning to switch this over to the setup I used for Azure in the merge?
There was a problem hiding this comment.
oh yes I left a review comment for this but forgot to post it :) yep, I was holding off on updating this since it'll need refactoring during the rebase anyway
| @@ -29,15 +29,8 @@ use json_models::{Events, Results}; | |||
| use super::spec::unified_runner::EntityMap; | |||
|
|
|||
| #[test] | |||
| #[ignore] | |||
There was a problem hiding this comment.
This will require an update to our script in drivers-atlas-testing; I'll make a PR there once this one is merged.
src/runtime/http.rs
Outdated
| @@ -1,17 +1,17 @@ | |||
| #[cfg(feature = "aws-auth")] | |||
| #[cfg(any(feature = "aws-auth", feature = "in-use-encryption-unstable"))] | |||
There was a problem hiding this comment.
oh yes I left a review comment for this but forgot to post it :) yep, I was holding off on updating this since it'll need refactoring during the rebase anyway
isabelatkinson
force-pushed
the
gcp-on-demand
branch
from
7b6161a to
c3688a4
Compare
This is going to be a slightly messy rebase, so I'm going to hold off on doing that until this PR is approved and I can squash my git history.