RUST-803 Conditionally use hello for monitoring
#600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Mar 21, 2022
|
Oh I just realized the grep I was using missed a lot of the legacy hellos, will push a new commit that fixes those. |
abr-egn
reviewed
Mar 23, 2022
src/test/util/mod.rs
Outdated
| @@ -82,14 +82,10 @@ impl TestClient { | |||
| .await; | |||
| session.mark_dirty(); | |||
|
|
|||
| let is_master = | |||
| RunCommand::new("admin".into(), doc! { "isMaster": 1 }, None, None).unwrap(); | |||
| let hello = RunCommand::new("admin".into(), doc! { "isMaster": 1 }, None, None).unwrap(); | |||
There was a problem hiding this comment.
Should this be using "hello"?
There was a problem hiding this comment.
This one I thought was required, since it's essentially an initial handshake. I realized that I can just reuse the hello_command method though, so I've updated it to that.
patrickfreed
commented
Mar 23, 2022
|
|
||
| #[cfg_attr(feature = "tokio-runtime", tokio::test)] | ||
| #[cfg_attr(feature = "async-std-runtime", async_std::test)] | ||
| async fn basic() { |
There was a problem hiding this comment.
this test seemed to be sufficiently covered by our end-to-end integration tests and is a bit too specific to the implementation, so I just decided to remove it rather than try to accommodate any more changes to it.
kmahar
reviewed
Mar 23, 2022
isabelatkinson
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-803
This PR updates the monitors in the driver to make use of
helloOk, a new (in 4.4.5) flag to the legacy hello command which can be used to determine if the server supports the newhellocommand. If it echos backhelloOk: true, all subsequent monitor checks should usehelloinstead of the legacy hello command. The initial check needs to always be legacy though in case the server doesn't support the newer one.The SDAM tests were synced as part of this.
There are a few remaining instances of the legacy hello command in the driver, all used for initial information requests or for deserialization purposes.