Skip to content

bump trust-dns-proto trust-dns-resolver #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

attila-lin
Copy link
Contributor

No description provided.

@bajanam bajanam requested a review from abr-egn March 14, 2022 19:06
@abr-egn
Copy link
Contributor

abr-egn commented Mar 14, 2022

Thanks for contributing! I've kicked off a test run, assuming that's green I'll merge this in.

@abr-egn
Copy link
Contributor

abr-egn commented Mar 14, 2022

Unfortunately, it looks like trust-dns-resolver 0.21.1 doesn't compile under our MSRV (1.49):

[2022/03/14 19:26:44.507]    Compiling trust-dns-resolver v0.21.1
[2022/03/14 19:26:44.507] error[E0658]: use of unstable library feature 'clamp'
[2022/03/14 19:26:44.507]    --> /home/ubuntu/.cargo/registry/src/github.com-1ecc6299db9ec823/trust-dns-resolver-0.21.1/src/dns_lru.rs:242:18
[2022/03/14 19:26:44.507]     |
[2022/03/14 19:26:44.507] 242 |                 .clamp(self.negative_min_ttl, self.negative_max_ttl);
[2022/03/14 19:26:44.507]     |                  ^^^^^
[2022/03/14 19:26:44.507]     |
[2022/03/14 19:26:44.507]     = note: see issue #44095 <https://github.com/rust-lang/rust/issues/44095> for more information
[2022/03/14 19:26:44.776] error: aborting due to previous error

@attila-lin
Copy link
Contributor Author

attila-lin commented Mar 15, 2022

Hello! Thank you with your reply.

Any plan with the updating of MSRV? I see a lot deps of this crate is outdated.

@abr-egn
Copy link
Contributor

abr-egn commented Mar 15, 2022

Talked about it with the team and we're going to bump our MSRV to 1.50.0, which should be sufficient for this change. Once that's in we can merge this :)

In the meanwhile, it looks like there are some compile failures unrelated to that:

[2022/03/14 19:19:46.369] error[E0308]: mismatched types
[2022/03/14 19:19:46.369]   --> src/srv.rs:84:17
[2022/03/14 19:19:46.369]    |
[2022/03/14 19:19:46.369] 83 |             let srv = match record.data() {
[2022/03/14 19:19:46.369]    |                             ------------- this expression has type `std::option::Option<&RData>`
[2022/03/14 19:19:46.369] 84 |                 RData::SRV(s) => s,
[2022/03/14 19:19:46.369]    |                 ^^^^^^^^^^^^^ expected enum `std::option::Option`, found enum `RData`
[2022/03/14 19:19:46.369]    |
[2022/03/14 19:19:46.369]    = note: expected enum `std::option::Option<&RData>`
[2022/03/14 19:19:46.369]               found enum `RData`

@attila-lin
Copy link
Contributor Author

Happy to hear that!

@abr-egn
Copy link
Contributor

abr-egn commented Mar 22, 2022

It turns out that due to incompatibilities with other dependencies we needed to bump trust-dns-proto and trust-dns-resolver as part of the larger MSRV update (#596), so I'm going to close out this PR. Thanks again for bringing this to our attention!

@abr-egn abr-egn closed this Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants