RUST-1133 Update driver to use the raw BSON API #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickfreed
commented
Jan 4, 2022
| let id = match bson_util::raw_get(doc.as_slice(), "_id")? { | ||
| Some(b) => b, | ||
| let mut doc = bson::to_raw_document_buf(d)?; | ||
| let id = match doc.get("_id")? { |
There was a problem hiding this comment.
I ended up using basically the same prepend _id logic here.
isabelatkinson
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-1133
We implemented some of the raw BSON functionality in the driver itself as a temporary measure until the BSON library had its own support for it. Now that it does, we can remove these driver-only implementations and update to use the BSON library's versions instead.