RUST-894 Unskip write_error::details test on sharded clusters #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karmenliang
requested review from
patrickfreed
and removed request for
patrickfreed
abr-egn
force-pushed
the
RUST-894/unskip-write_error-test
branch
from
3656781 to
3cd7242
Compare
|
This just needed a minor update to skip servers that don't have the fix; @patrickfreed and @isabelatkinson please take a look :) |
| // TODO: RUST-894 unskip once SERVER-58399 is fixed. | ||
| if client.server_version_lt(5, 0) || client.is_sharded() { | ||
| if client.server_version_lt(5, 0) { | ||
| // SERVER-58399 |
There was a problem hiding this comment.
I think we can remove this ticket reference now that the issue on sharded clusters is resolved
There was a problem hiding this comment.
I'd prefer to leave it there as a breadcrumb for why servers <5.0 can't run the test.
isabelatkinson
approved these changes
Jan 28, 2022
patrickfreed
approved these changes
Feb 1, 2022
abr-egn
force-pushed
the
RUST-894/unskip-write_error-test
branch
from
29e47da to
b1accbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-894
Since SERVER-58399 is fixed, the
write_errortest can be unskipped.