RUST-781 Remove unwraps from examples #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
To clarify: did you also check the examples included in the docstrings of modules / types? The changes here are good, but the scope of the ticket also includes those examples, since they'll be included in the docs.rs page for the driver. These ones actually won't be on docs.rs, but they should be included in the MongoDB documentation. I'm noticing now that a ticket may never have been filed for some of the older ones unfortunately, so once this PR goes in I'll go ahead and do that.
|
Apologies, I should have mentioned - yes, I looked for docstrings with |
patrickfreed
approved these changes
Sep 27, 2021
abr-egn
force-pushed
the
RUST-781/example-nounwrap
branch
from
daf6650 to
7ef2cae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-781
This removes uses of
unwrapfrom example code; only one of these was actually in the example portion. There are a bunch of remainingunwraps but they're in various places (macros, closures) that would be nontrivial to remove and not produce any benefit.