Skip to content

RUST-993 Implement Clone for Collection<T> #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/coll/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,23 @@ use crate::{
/// # }
/// ```

#[derive(Debug, Clone)]
#[derive(Debug)]
pub struct Collection<T> {
inner: Arc<CollectionInner>,
_phantom: std::marker::PhantomData<T>,
}

// Because derive is too conservative, derive only implements Clone if T is Clone.
// Collection<T> does not actually store any value of type T (so T does not need to be clone).
impl<T> Clone for Collection<T> {
fn clone(&self) -> Self {
Self {
inner: self.inner.clone(),
_phantom: Default::default(),
}
}
}

#[derive(Debug)]
struct CollectionInner {
client: Client,
Expand Down