RUST-950 Enable connection to a load balancer #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Aug 3, 2021
| // TODO RUST-653 Remove this when load balancer work is ready for release. | ||
| #[builder(default, setter(skip))] | ||
| #[serde(skip)] | ||
| pub(crate) allow_load_balanced: bool, |
There was a problem hiding this comment.
This awkward double-flag construction allows load_balanced to be populated by the URI/TXT parsing as it will be on release, but prevents that from being used outside of tests that have access to set allow_load_balanced to be true.
patrickfreed
reviewed
Aug 4, 2021
patrickfreed
reviewed
Aug 5, 2021
abr-egn
force-pushed
the
RUST-950/load-balancer-connection
branch
from
4f2644a to
afd1b72
Compare
src/srv.rs
Outdated
| @@ -189,11 +191,28 @@ impl SrvResolver { | |||
| "replicaset" => { | |||
| config.replica_set = Some(parts[1].into()); | |||
| } | |||
| "loadBalanced" => { | |||
There was a problem hiding this comment.
This should be lowercase. See Line 187.
There was a problem hiding this comment.
Good catch, thank you!
|
This has broken all tests with auth enabled; converted to draft while I track that down. |
Ah, found it; I'd broken |
patrickfreed
reviewed
Aug 9, 2021
isabelatkinson
approved these changes
Aug 10, 2021
patrickfreed
approved these changes
Aug 11, 2021
abr-egn
force-pushed
the
RUST-950/load-balancer-connection
branch
from
c340c54 to
78bfb11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-950
This implements the connection establishment portion of load balancer support, i.e.:
loadBalancedURI/TXT optionserviceIdconnection pool trackingThe work here happened to also encompass RUST-955.