Skip to content

RUST-773 Update CMAP spec tests to prevent cross-test failpoint interference #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ the addition of the following fields to each test:
- ``failPoint``: optional, a document containing a ``configureFailPoint``
command to run against the endpoint being used for the test.

- ``poolOptions.appName`` (optional): appName attribute to be set in connections, which will be affected by the fail point.

Spec Test Match Function
========================

Expand Down Expand Up @@ -213,3 +215,4 @@ The following tests have not yet been automated, but MUST still be tested
#. A user MUST be able to subscribe to Connection Monitoring Events in a manner idiomatic to their language and driver
#. When a check out attempt fails because connection set up throws an error,
assert that a ConnectionCheckOutFailedEvent with reason="connectionError" is emitted.

Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "error during minPoolSize population clears pool",
"runOn": [
{
"minServerVersion": "4.2.0"
"minServerVersion": "4.9.0"
}
],
"failPoint": {
Expand All @@ -14,21 +14,25 @@
},
"data": {
"failCommands": [
"isMaster"
"isMaster",
"hello"
],
"closeConnection": true
"closeConnection": true,
"appName": "poolCreateMinSizeErrorTest"
}
},
"poolOptions": {
"minPoolSize": 1
"minPoolSize": 1,
"backgroundThreadIntervalMS": 50,
"appName": "poolCreateMinSizeErrorTest"
},
"operations": [
{
"name": "ready"
},
{
"name": "waitForEvent",
"event": "ConnectionClosed",
"event": "ConnectionPoolCleared",
"count": 1
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,24 @@ style: integration
description: error during minPoolSize population clears pool
runOn:
-
# required for blockConnection in fail point
minServerVersion: "4.2.0"
# required for appName in fail point
minServerVersion: "4.9.0"
failPoint:
configureFailPoint: failCommand
# high amount to ensure not interfered with by monitor checks.
mode: { times: 50 }
data:
failCommands: ["isMaster"]
failCommands: ["isMaster","hello"]
closeConnection: true
appName: "poolCreateMinSizeErrorTest"
poolOptions:
minPoolSize: 1
backgroundThreadIntervalMS: 50
appName: "poolCreateMinSizeErrorTest"
operations:
- name: ready
- name: waitForEvent
event: ConnectionClosed
event: ConnectionPoolCleared
count: 1
# ensure pool doesn't start making new connections
- name: wait
Expand Down