Skip to content

Use Arc::clone in Collection::clone_with_type #464

Closed
@PhotonQuantum

Description

@PhotonQuantum

Current clone_with_type implementation includes calling builder and constructing a new CollectionInner instance.
Given that CollectionInner is wrapped in an Arc, and generic T isn't included in CollectionInner, is there any possibility that we refactor clone_with_type into Self{inner: self.inner.clone(), _phantom: Default::default()}?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions