Skip to content

Implement URI options spec #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 42 commits into from
Jan 17, 2019
Merged

Implement URI options spec #386

Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
90a0eb2
re-work test harness
prashantmital Nov 16, 2018
bded8a4
add JSON spec-test files
prashantmital Nov 16, 2018
3ef53cc
add new options from specification
prashantmital Nov 16, 2018
fb04075
change exception raised by invalid value of zlibcompressionlevel
prashantmital Nov 16, 2018
f7a7f6f
add dummy PEM files for tests
prashantmital Nov 19, 2018
1991e18
refactor URI parsing logic
prashantmital Nov 27, 2018
17a506b
cleanup option name dictionaries
prashantmital Nov 27, 2018
3bf9167
cleanup validation code and extend functionality to kwargs
prashantmital Nov 27, 2018
1152e41
robustify deprecated option handling
prashantmital Nov 27, 2018
57bbe35
robustify socketKeepAlive deprecation warning test
prashantmital Nov 28, 2018
d270963
preserve case information when parsing options
prashantmital Nov 28, 2018
776e2e8
try warnings magic
prashantmital Nov 28, 2018
f32a3bd
break out spec tests into individual tests
prashantmital Nov 28, 2018
f6e6911
stringify test names to avoid py2.x unicode errors
prashantmital Nov 28, 2018
baa4ab0
clear warning registry during spec test setup
prashantmital Nov 29, 2018
9635bd6
remove 'path' from uri option names
prashantmital Dec 4, 2018
fa60f0f
remove unnecessary trailing commas
prashantmital Dec 5, 2018
5a0a061
augment comment to specify MongoClient constructor options
prashantmital Dec 5, 2018
bdbfed0
add link to python warnings-related issue
prashantmital Dec 5, 2018
8f4f973
incorporate new JSON tests
prashantmital Dec 18, 2018
495c35c
undo removal of public API methods
prashantmital Dec 18, 2018
c93dd85
undo removal of public API methods
prashantmital Dec 18, 2018
ee724cc
get more spec tests to pass
prashantmital Dec 18, 2018
e2b3e0d
get spec tests to pass
prashantmital Dec 19, 2018
e4d3b4c
ensure options are compared correctly (they were not being compared b…
prashantmital Dec 19, 2018
8e30865
cleanup cruft
prashantmital Dec 21, 2018
46a4597
update docs
prashantmital Dec 24, 2018
f426fb2
add missing link
prashantmital Dec 24, 2018
8c93d05
fix typo
prashantmital Dec 24, 2018
01efc7c
update/resync test JSON files
prashantmital Jan 4, 2019
478f238
update docstring
prashantmital Jan 8, 2019
0a73bbe
use more efficient loop pattern
prashantmital Jan 8, 2019
7829c96
compressor validator now accepts iterables as well as strings
prashantmital Jan 11, 2019
be89558
use try except instead of type comparison
prashantmital Jan 11, 2019
5788f44
implement case insensitive dictionary
prashantmital Jan 14, 2019
afd789c
add some tests to check proper parsing and warning when ingesting tls…
prashantmital Jan 15, 2019
e030962
fix failing py3 tests
prashantmital Jan 15, 2019
fb5a20b
update docstrings
prashantmital Jan 17, 2019
f691860
update docstrings
prashantmital Jan 17, 2019
43da062
update docstrings
prashantmital Jan 17, 2019
eb4c175
make CaseInsensitiveDictionary private
prashantmital Jan 17, 2019
d5082fd
explicitly specified values of tlsAllow* options override values impl…
prashantmital Jan 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
robustify socketKeepAlive deprecation warning test
  • Loading branch information
@prashantmital
prashantmital committed Jan 8, 2019
commit 57bbe35c5d8edddb58dd53e959988aed9badccd7
4 changes: 2 additions & 2 deletions test/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,8 +882,8 @@ def test_socketKeepAlive(self):
with warnings.catch_warnings(record=True) as ctx:
warnings.simplefilter("always")
client = rs_or_single_client(socketKeepAlive=socketKeepAlive)
self.assertIn("The socketKeepAlive option is deprecated",
str(ctx[0]))
self.assertTrue(any("The socketKeepAlive option is deprecated"
in str(k) for k in ctx))
pool = get_pool(client)
self.assertEqual(socketKeepAlive,
pool.opts.socket_keepalive)
Expand Down