Skip to content

PYTHON-5421 Make parse_uri() return "options" as a dict rather than _CaseInsensitiveDictionary #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2025
Merged

PYTHON-5421 Make parse_uri() return "options" as a dict rather than _CaseInsensitiveDictionary #2413

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8028eb2
add method to convert case insensitive dict to plain dict
sleepyStick Jun 30, 2025
3d5ce00
make it a plain dictionary in parse_uri
sleepyStick Jun 30, 2025
e26e78a
options is no longer case insensitive, modifying tests to reflect that
sleepyStick Jun 30, 2025
45de7e6
update tests
sleepyStick Jul 1, 2025
fad3686
introduce frozenset of proper cased uri options
sleepyStick Jul 1, 2025
6f705ba
fix typo and tests
sleepyStick Jul 1, 2025
988afae
test can use case insensitive dict
sleepyStick Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
options is no longer case insensitive, modifying tests to reflect that
  • Loading branch information
@sleepyStick
sleepyStick committed Jun 30, 2025
commit e26e78a1ab58b7f330c557f4849022f30ae727c4
4 changes: 2 additions & 2 deletions test/asynchronous/test_discovery_and_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ async def create_mock_topology(uri, monitor_class=DummyMonitor):
replica_set_name = None
direct_connection = None
load_balanced = None
if "replicaset" in parsed_uri["options"]:
replica_set_name = parsed_uri["options"]["replicaset"]
if "replicaSet" in parsed_uri["options"]:
replica_set_name = parsed_uri["options"]["replicaSet"]
if "directConnection" in parsed_uri["options"]:
direct_connection = parsed_uri["options"]["directConnection"]
if "loadBalanced" in parsed_uri["options"]:
Expand Down
4 changes: 2 additions & 2 deletions test/test_discovery_and_monitoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ def create_mock_topology(uri, monitor_class=DummyMonitor):
replica_set_name = None
direct_connection = None
load_balanced = None
if "replicaset" in parsed_uri["options"]:
replica_set_name = parsed_uri["options"]["replicaset"]
if "replicaSet" in parsed_uri["options"]:
replica_set_name = parsed_uri["options"]["replicaSet"]
if "directConnection" in parsed_uri["options"]:
direct_connection = parsed_uri["options"]["directConnection"]
if "loadBalanced" in parsed_uri["options"]:
Expand Down
Loading