-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON 5212 - Use asyncio.loop.sock_connect in _async_create_connection #2383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d1cc4f9
PYTHON 5212 - Use asyncio.loop.sock_connect in _async_create_connection
NoahStapp 5a87b91
Update unix sockets
NoahStapp 3521829
Asynchronous timeout
NoahStapp 9bb2e6d
Merge branch 'master' into PYTHON-5212-1
NoahStapp 9ce66b9
Fix asyncio.TimeoutError handling
NoahStapp 4e21b63
Restore socket timeout after connection + add changelog
NoahStapp af944e7
Add regression test
NoahStapp 92fae2c
Fix typing
NoahStapp e08da84
Cleanup
NoahStapp 73d41e1
Address review
NoahStapp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Cleanup
- Loading branch information
commit e08da843f4193cd86a49f911f27373ec9b8e3cbc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry only adding 100ms will be flaky, can we make this 1 full second?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, I was slightly too optimistic about the EG host performance.