PYTHON-4295 Fix Installation of Crytography on PyPy3.8 #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Mar 22, 2024
| @@ -33,6 +33,7 @@ SSL=${SSL:-nossl} | |||
| TEST_ARGS="${*:1}" | |||
| PYTHON=$(which python) | |||
| export PIP_QUIET=1 # Quiet by default | |||
| export PIP_PREFER_BINARY=1 # Prefer binary dists by default | |||
There was a problem hiding this comment.
Can you explain how this fixes the error? Why doesn't --prefer-binary work?
There was a problem hiding this comment.
Oh I see, this now applies to OCSP and other pip installs.
ShaneHarvey
approved these changes
Mar 22, 2024
NoahStapp
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.