PHPLIB-70: Resource CRUD prototypes #5
Conversation
| * @param string $databaseName | ||
| * @return Result | ||
| */ | ||
| public function dropDatabase($databaseName) |
There was a problem hiding this comment.
Should the Database object have __toString() method and this code explicitly do (string)$databaseName ?
There was a problem hiding this comment.
If we did that and allowed the argument to be either a string or a Database instance, would we get into trouble with dropCollection()? I would expect a Collection's __toString() method to return its full namespace, as we do in the 1.x driver. I'd rather not invite the inconsistency.
There was a problem hiding this comment.
The proto should definetly not be string|Database, it should be string - but if it does (string) casting inside the method it implicitly allows the Database object to work seamlessly.
as for dropCollection() returning fully qualified namespace...... mmmmh.....
We can move this to a separate, pedantic test class later.
| * @return Result | ||
| */ | ||
| public function drop() | ||
| { |
There was a problem hiding this comment.
What happens to this instance after calling drop?
There was a problem hiding this comment.
exec('halt -f');
exit(0);There was a problem hiding this comment.
But really, we don't need to do anything. A Collection instance doesn't require anything to actually exist in the database, so there's nothing to clean up in PHP. If we started doing stuff like caching index enumeration class, perhaps, but not now.
There was a problem hiding this comment.
$collection = $db->createCollection("foo", array("storageEngineOptions" => array("xyz"));
$collection->insert(array("foo" => "bar"));
$collection->drop();
$collection->insert(array("foo" => "bar")); // This will create different configured collection then above
|
lgtm |
|
Do we now how stubs for the entire API we want before the alpha release? |
|
@bjori: I left out |
https://jira.mongodb.org/browse/PHPLIB-70