Compatibility fixes for PHPC and HHVM #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perhaps, an alternative could be to use access properties instead of array elements?
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| namespace MongoDB\Operation; | |||
|
|
|||
| require 'src/functions.php'; | |||
|
|
|||
There was a problem hiding this comment.
Composer should handle autoloading and requiring src/functions.php, so this shouldn't be necessary. Can you try regenerating your autoloaders again with composer dump-autoload or composer update?
There was a problem hiding this comment.
You're right - you can strip this commit out.
…he return value with a cast to 'object'
Unless the operation returns a scalar or custom value (e.g. Count, CreateIndexes), we should explicitly convert documents to stdClass instances to return. This will ultimately be made configurable once PHPLIB-112 is implemented. A manual cast (of arrays to objects) was also necessary until PHPC-318 is implemented.
Normalizing top-level documents as arrays will allow single and multi-document checks to be more flexible. This will not extend to embedded documents, where we'll still need to be explicit. Additionally, assertSameDocuments can now operate on any array or Traversable without needing to set its own type map.
|
@derickr: Please let me know if this works for you. |
jmikola
added a commit
that referenced
this pull request
Jun 19, 2015
GromNaN
added a commit
to GromNaN/mongo-php-library
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.