Validate composer.json as part of CI workflows #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Sep 9, 2024
alcaeus
force-pushed
the
composer-validate
branch
from
37347a9 to
1ec5974
Compare
jmikola
reviewed
Sep 9, 2024
| @@ -0,0 +1,30 @@ | |||
| name: "Check validity of composer.json" | |||
There was a problem hiding this comment.
Yes, this was done to make sure we're alerted to changes to the pie schema, especially as it may change during the development process. I can copy the workflow over to PHPLIB 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1624 (comment), this PR introduces a GitHub Actions Workflow to validate composer.json and ensure it will work. Based on that validation, I've added the missing
descriptionfield, making it as minimalist as that of PHPLIB.