Add showExpandedEvents to change stream pipeline stage #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozza
requested changes
Jul 6, 2022
There was a problem hiding this comment.
Looks good.
The Scala API needs updating to add the showExpandedEvents to ChangeStreamObservable. It should be simple it just wraps the reactive streams API. Scaladoc doesn't support custom tags - so just use @note for the server version.
| @@ -986,9 +988,9 @@ public OperationResult executeCreateCollection(final BsonDocument operation) { | |||
| ClientSession session = getSession(arguments); | |||
|
|
|||
| // In Java driver there is a separate method for creating a view, but in the unified test CRUD format | |||
| // views and collections are both created with the createCollection operation. We branch off the "viewOn" key's | |||
| // views and collections are both created with the createCollection operation. We branch off of key | |||
There was a problem hiding this comment.
Nit: The sentence is hard to parse
rozza
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-4585