Improved comment of new connectionsPerHost default #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed the increase is from the value used by the superceded Mongo class.
jyemin
added a commit
that referenced
this pull request
Nov 26, 2012
JAVA-682: Improved comment of new connectionsPerHost default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing comment on the new default for connectionsPerHost simply said that the value has been increased from 10 to 100. The new comment makes it explicit that this is a change from the value used by the old Mongo class to the value used by the new MongoClient class.
Without this, in the future once the MongoClient class is commonly used, the original comment may be confusing, prompting the reader to wonder what version of the MongoClient class the change was introduced in.