Add native-image.properties that defers the inicialization of some classes#527
Closed
jkremser wants to merge 2 commits intomongodb:masterfrom
Closed
Add native-image.properties that defers the inicialization of some classes#527jkremser wants to merge 2 commits intomongodb:masterfrom
jkremser wants to merge 2 commits intomongodb:masterfrom
Conversation
… com.mongodb.UnixServerAddress and com.mongodb.internal.connection.SnappyCompressor to the run-time
Member
|
Hi @jkremser, Thanks for the ticket, I've added https://jira.mongodb.org/browse/JAVA-3537 to track this feature request. Ross |
Author
|
should I close this one on behalf of rozza#345 ? |
Member
|
Hi @jkremser - I rebased your change, made a minor change (removed the clirr addition) and once ok'd it will be merged into master for the forthcoming 4.0 release. You can close this or I'll close once its in master. Once again, many thanks for bringing this to our attention and providing the original PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraalVM's native-image tool can create executable self-contained applications out of jar files by doing a lot of magic, like evaluating static initializers during the compilation, making a snapshot of the memory heap, etc. However sometimes some classes' initialization need to be deferred to run-time to pass the build. This PR adds the property file that is read by the
native-imagetool during the compilation and the argumets are appended to the build tool. It's harmless for the jar itself and will be ignored by all the other tools.Namely, it adds these classes:
com.mongodb.UnixServerAddresscom.mongodb.internal.connection.SnappyCompressor