Support Range Indexes as GA. #1465
Conversation
- Add prose tests. - Update specification tests. - Move duplicated code to EncryptionFixture. JAVA-5537
JAVA-5537
vbabanin
requested review from
a team and
stIncMale
and removed request for
a team
There was a problem hiding this comment.
I've consolidated the common initialization logic, previously repeated across encryption tests, into a new EncryptionFixture.
JAVA-5537
JAVA-5537
JAVA-5537
JAVA-5557
JAVA-5557
JAVA-5557
| @@ -305,11 +305,10 @@ BsonDocument getRunCommandResult(final BsonDocument collectionOptions, final Bso | |||
| response = database.runCommand(clientSession, command, readPreference, BsonDocument.class); | |||
| } | |||
| } | |||
| response.remove("ok"); | |||
There was a problem hiding this comment.
According to the legacy test format specification:
If the operation returns a raw command response, e.g., from runCommand, then compare only the fields present in the expected result document.
Therefore, we should not remove any fields from the response. Instead, we should only compare the fields that are explicitly expected and ignore any additional fields that are not specified in the expected results.
JAVA-5441
vbabanin
changed the title
| @Nullable | ||
| public Integer getTrimFactor() { |
There was a problem hiding this comment.
It's weird that this method was not @Nullable previously, as there was nothing that prevented it from returning null.
driver-sync/src/test/functional/com/mongodb/fixture/EncryptionFixture.java
Show resolved
Hide resolved
| kmsProviders = new HashMap<>(); | ||
| Map<String, Object> localProviderMap = new HashMap<>(); | ||
| localProviderMap.put("key", | ||
| Base64.getDecoder().decode( | ||
| "Mng0NCt4ZHVUYUJCa1kxNkVyNUR1QURhZ2h2UzR2d2RrZzh0cFBwM3R6NmdWMDFBMUN3YkQ5aXRRMkhGRGdQV09wOGVNYUMxT2k3NjZKelhaQmRCZ" | ||
| + "GJkTXVyZG9uSjFk")); | ||
| kmsProviders.put("local", localProviderMap); |
There was a problem hiding this comment.
👍 Thank you for removing all this code duplication, and making tests clearer.
...ional/com/mongodb/client/AbstractClientSideEncryptionRangeDefaultExplicitEncryptionTest.java
Outdated
Show resolved
Hide resolved
...ional/com/mongodb/client/AbstractClientSideEncryptionRangeDefaultExplicitEncryptionTest.java
Show resolved
Hide resolved
...ional/com/mongodb/client/AbstractClientSideEncryptionRangeDefaultExplicitEncryptionTest.java
Outdated
Show resolved
Hide resolved
...ional/com/mongodb/client/AbstractClientSideEncryptionRangeDefaultExplicitEncryptionTest.java
Outdated
Show resolved
Hide resolved
...ional/com/mongodb/client/AbstractClientSideEncryptionRangeDefaultExplicitEncryptionTest.java
Outdated
Show resolved
Hide resolved
...m/mongodb/reactivestreams/client/ClientSideEncryptionRangeDefaultExplicitEncryptionTest.java
Outdated
Show resolved
Hide resolved
…entSideEncryptionRangeDefaultExplicitEncryptionTest.java Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>
Add JavaDoc. JAVA-5537
| * @param trimFactor the trim factor | ||
| * @return this | ||
| * @since 5.2 | ||
| */ | ||
| public RangeOptions setTrimFactor(final Integer trimFactor) { | ||
| public RangeOptions setTrimFactor(@Nullable final Integer trimFactor) { |
There was a problem hiding this comment.
Nit: Can we rename this to trimFactor. Using the API having the set prefix really sticks out.
There was a problem hiding this comment.
Absolutely, good catch! I've renamed it to trimFactor().
JAVA-5537
JAVA-5537
JAVA-5441