Handle interrupts: synchronous KeyManagementService uses Socket IO (open, read, write), which is interruptible in a virtual thread
#1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(open, read, write), which is interruptible in a virtual thread JAVA-5139
JAVA-5139
jyemin
reviewed
Sep 26, 2023
| @@ -348,7 +350,9 @@ private void decryptKeys(final MongoCryptContext cryptContext) { | |||
| } | |||
| cryptContext.completeKeyDecryptors(); | |||
| } catch (Throwable t) { | |||
| throw wrapInClientException(t); | |||
| throw translateInterruptedException(t, "Interrupted while reading") | |||
There was a problem hiding this comment.
Is it necessary to translate interrupted exceptions both here and in the KeyManagementService (which this is calling)?
There was a problem hiding this comment.
Only if we want to add messages like "interrupted while connecting/writing/reading" which is what we do for streams, and why I did it this way here. But if it's fine to just have a single message "interrupted while doing IO", or no message at all, I'll be happy to remove the translating code from Crypt.
driver-sync/src/main/com/mongodb/client/internal/KeyManagementService.java
Outdated
Show resolved
Hide resolved
jyemin
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is very similar to #1203, which is why I assigned the same reviewers.
JAVA-5139