Skip to content

Handle Socket IO interruptibility #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 7, 2023
Merged

Handle Socket IO interruptibility #1189

merged 4 commits into from
Sep 7, 2023

Conversation

@stIncMale
Copy link
Member

@stIncMale stIncMale commented Sep 6, 2023

@stIncMale stIncMale requested a review from jyemin September 6, 2023 23:21
@stIncMale stIncMale self-assigned this Sep 6, 2023
@stIncMale
Copy link
Member Author

stIncMale commented Sep 7, 2023 •
edited
Loading

@jyemin in jyemin@f100207, you made a change in DefaultServer to avoid masking the MongoInterruptedException. I'll deal with it by addressing the root cause (after I figure out why the tests are failing): the code that calls SdamServerDescriptionManager.handleExceptionBeforeHandshake/handleExceptionAfterHandshake must not lose the original exception regardless whether it was caused by an interrupt or not.

Update: done.

@stIncMale stIncMale marked this pull request as draft September 7, 2023 00:16
@stIncMale stIncMale marked this pull request as ready for review September 7, 2023 05:49
jyemin
jyemin approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stIncMale
Copy link
Member Author

stIncMale commented Sep 7, 2023

The tests in https://github.com/mongodb/mongo-java-driver/tree/JAVA_5109 pass when run against the changes in this PR.

@stIncMale
Copy link
Member Author

stIncMale commented Sep 7, 2023

Looks like the tests fail because the server broke something:

@stIncMale stIncMale merged commit 7ed5e70 into mongodb:master Sep 7, 2023
@stIncMale stIncMale deleted the JAVA-4646 branch September 7, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jyemin jyemin jyemin approved these changes

Assignees

@stIncMale stIncMale

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stIncMale @jyemin