-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Replace @Evolving with @Sealed where appropriate
#1141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace @Evolving with @Sealed where appropriate
#1141
Conversation
I changed only program elements annotated with `@Beta` because changing others is not a backward-compatible change.
| /** | ||
| * Signifies that the annotated class or interface should be treated as sealed: | ||
| * it must not be extended or implemented. | ||
| * it must not be extended or implemented by users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the documentation change.
| * </tr> | ||
| * </table> | ||
| * | ||
| * @see Sealed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the documentation change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor and optional: the example is the same for the last two items.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because both apply there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evolving should have been annotated with @Sealed rather than @Evolving, but the idea of @Sealed did not come at that time, and now it will be a breaking change, even though one may be quite sure that no one extended Evolving.
|
@stIncMale I think a change like this deserves a JAVA ticket first. |
|
@jyemin Done. Added the link to the PR description. |
katcharov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| * </tr> | ||
| * </table> | ||
| * | ||
| * @see Sealed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor and optional: the example is the same for the last two items.
I changed only program elements annotated with
@Betabecause changing others is not a backward-compatible change.JAVA-5020