Stop creating the ECC collection in v2 of queryable encryption #1110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAVA-4858
…ument The updated CSFLE tests rely on this behavior. It is specified in https://github.com/mongodb/specifications/tree/master/source/transactions/tests#null-values and the CSFLE tests spec is based on the transaction tests spec according to https://github.com/mongodb/specifications/tree/master/source/client-side-encryption/tests#spec-test-format. JAVA-4858
stIncMale
requested review from
katcharov and
vbabanin
and removed request for
katcharov
JAVA-4858
Member
Author
jyemin
requested changes
Apr 24, 2023
Collaborator
jyemin
left a comment
jyemin
left a comment
There was a problem hiding this comment.
LGTM on the Javadoc. A few implementation questions/comments.
driver-core/src/main/com/mongodb/internal/operation/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/operation/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/operation/CreateCollectionOperation.java
Outdated
Show resolved
Hide resolved
JAVA-4858
jyemin
approved these changes
Apr 24, 2023
vbabanin
reviewed
Apr 25, 2023
driver-core/src/main/com/mongodb/internal/operation/ServerVersionHelper.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/operation/CreateCollectionOperation.java
Show resolved
Hide resolved
driver-core/src/main/com/mongodb/internal/operation/CreateCollectionOperation.java
Show resolved
Hide resolved
vbabanin
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encryptedFieldsspecified now requires MongoDB 7.0+, which is why I specified@mongodb.server.release 7.0everywhereencryptedFieldsis used (the driver does not do the check when dropping a collection, but it still does not seem meaningful to documentDropCollectionOptions.encryptedFieldsany different than other places).CreateCollectionOptions.encryptedFields/DropCollectionOptions.encryptedFieldswere not documented as@Beta, which appears to be a mistake, given that the whole queryable encryption feature is in preview. I documented them as such.JAVA-4858