Add RewrapManyDataKeyProseTest #1083
Conversation
rozza
left a comment
rozza
left a comment
There was a problem hiding this comment.
Couple of minor naming changes, to follow current conventions.
Other than that LGTM
Note: I've added JAVA-4879 to track improving the discoverability of prose tests and to define a clearer naming convention / grouping. As I'm not sure all prose tests have been implemented.
| import static com.mongodb.client.Fixture.getMongoClientSettingsBuilder; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| public abstract class AbstractRewrapManyDataKeyProseTest { |
There was a problem hiding this comment.
Rename to AbstractClientEncryptionRewrapManyDataKeyProseTest to aid future discovery
There was a problem hiding this comment.
Many tests are named AbstractClientSideEncryption... - is this just a minor inconsistency, or is there some difference?
There was a problem hiding this comment.
This is the weirdness that I hope JAVA-4879 will clean up.
Probably a mix of inconsistent naming and grouping for the CSFLE Prose tests - its not clear which ones map to which prose tests.
| import static com.mongodb.client.Fixture.getMongoClient; | ||
| import static com.mongodb.client.Fixture.getMongoClientSettingsBuilder; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
There was a problem hiding this comment.
Lets add a comment to the prose test in the spec
| import com.mongodb.client.vault.ClientEncryptions; | ||
| import com.mongodb.reactivestreams.client.syncadapter.SyncMongoClient; | ||
|
|
||
| public class RewrapManyDataKeyProseTest extends AbstractRewrapManyDataKeyProseTest { |
There was a problem hiding this comment.
Rename to ClientEncryptionRewrapManyDataKeyProseTest to aid future discovery
2 participants
JAVA-4698