Fix MixedBulkWriteOperation such that it does not leak MongoWriteConcernWithResponseException to users

[stIncMale]

JAVA-4775

[stIncMale]

Now that the leak is fixed, we can expect MongoWriteConcernException here.

[rozza]

FYI this can also be written as:

MongoWriteConcernException e = assertThrows(MongoWriteConcernException.class, () ->  collection.insertOne(new Document()));
assertEquals(91, e.getCode());

[stIncMale]

Thank you, I have not realized assertThrows returns the thrown exception :) Done.

[stIncMale]

Changed this because I found the new form easier to understand (I was trying to understand what's going on, not very successfully, though).

[rozza]

Should there be a separate catch for MongoWriteConcernWithResponseException to make this easier to understand?

[stIncMale]

Currently we have

} catch (MongoException exception) {
    if (!retryState.isFirstAttempt() && !(exception instanceof MongoWriteConcernWithResponseException)) {
        addRetryableWriteErrorLabel(exception, maxWireVersion);
    }
    handleMongoWriteConcernWithResponseException(retryState, false);
    throw exception;
}

with the change you propose we will have

} catch (MongoWriteConcernWithResponseException exception) {
    handleMongoWriteConcernWithResponseException(retryState, false);
    throw exception;
} catch (MongoException exception) {
    if (!retryState.isFirstAttempt()) {
        addRetryableWriteErrorLabel(exception, maxWireVersion);
    }
    handleMongoWriteConcernWithResponseException(retryState, false);
    throw exception;
}

The current code is shorter and does not have code duplication, the proposed code does not have the instanceof check. To me the current approach seems the lesser of two evils.

[rozza]

Looks good - added a couple of comments for consideration only

[rozza]

FYI this can also be written as:

MongoWriteConcernException e = assertThrows(MongoWriteConcernException.class, () ->  collection.insertOne(new Document()));
assertEquals(91, e.getCode());

[rozza]

Should there be a separate catch for MongoWriteConcernWithResponseException to make this easier to understand?

[jyemin]

Suggested change

	assertThrows(MongoWriteConcernException.class, () -> {
	assertThrows(MongoWriteConcernException.class, () -> collection.insertOne(new Document()));

If it's asserting that it throws MongoWriteConcernException it can't also throw MongoWriteConcernWithResponseException

[stIncMale]

assertThrows(MongoWriteConcernException.class, ...) verifies that MongoWriteConcernException is thrown. What if a different exception is thrown? - it simply reports that. I want to have the The internal exception leaked message when the different exception is MongoWriteConcernWithResponseException, and I don't see another way of achieving this. Of course, if this happens, both assertions will fail with the inner assertion being the cause of the outer one.

[jyemin]

It seems overly complicated structure just to get a more helpful failure message, but I can live with it.