Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2448 update golang/x/net to latest #999

Merged
merged 7 commits into from
Jun 27, 2022
Merged

GODRIVER-2448 update golang/x/net to latest #999

merged 7 commits into from
Jun 27, 2022

Conversation

prestonvasquez
Copy link
Collaborator

@prestonvasquez prestonvasquez commented Jun 24, 2022 •
edited
Loading

GODRIVER-2448

Update the golang/x/net go dependency to latest to help prevent against denial of service attacks.

Notes

[2022/06/27 15:43:37.914] go: golang.org/x/net@v0.0.0-20220624214902-1bab6f366d9e requires
[2022/06/27 15:43:37.914] 	golang.org/x/sys@v0.0.0-20220520151302-bc2c85ada10a: missing go.sum entry; to add it:
[2022/06/27 15:43:37.914] 	go mod download golang.org/x/sys

../../go/pkg/mod/github.com/xdg-go/stringprep@v1.0.2/profile.go:4:2: missing go.sum entry for module providing package golang.org/x/text/unicode/norm (imported by github.com/xdg-go/stringprep); to add:
	go get github.com/xdg-go/stringprep@v1.0.2

qingyang-hu
qingyang-hu approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I don't see a reason to exclude the README.

matthewdale
matthewdale reviewed Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run go mod vendor and commit the updated "vendor" directory.

go.mod
@@ -22,6 +22,7 @@ require (
github.com/xdg-go/stringprep v1.0.2
github.com/youmark/pkcs8 v0.0.0-20181117223130-1be2e3e5546d
golang.org/x/crypto v0.0.0-20201216223049-8b5274cf687f
golang.org/x/net v0.0.0-20220624214902-1bab6f366d9e // indirect
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: Consider adding a comment that mentions we have this indirect dependency because it resolves CVE-2021-44716.

matthewdale
matthewdale approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

qingyang-hu
qingyang-hu approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qingyang-hu qingyang-hu mentioned this pull request Jun 27, 2022
Closed
@prestonvasquez prestonvasquez merged commit e5e6d24 into master Jun 27, 2022
@prestonvasquez prestonvasquez deleted the GODRIVER-2448 branch June 27, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingyang-hu qingyang-hu qingyang-hu approved these changes

@matthewdale matthewdale matthewdale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prestonvasquez @matthewdale @qingyang-hu