Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2156 Enable gosimple linter. #795

Merged
merged 1 commit into from
Nov 16, 2021
Merged

GODRIVER-2156 Enable gosimple linter. #795

merged 1 commit into from
Nov 16, 2021

Conversation

matthewdale
Copy link
Collaborator

Enable the gosimple linter and make suggested simplifications.

benjirewis
benjirewis approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endlessly fascinated by these linters 😆 ; I wonder if this one is just a set of regexes looking for common over-complications? Unrelatedly, I also wonder what linters we're missing that ADL uses.

gabbyasuncion
gabbyasuncion approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@gabbyasuncion gabbyasuncion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also really fascinated by these linters! How do you find them / choose which ones to use?

@matthewdale
Copy link
Collaborator Author

@gabbyasuncion most of the linters we're trying to enable are the golangci-lint enabled by default linters.

@matthewdale matthewdale merged commit 49fed90 into mongodb:master Nov 16, 2021
gabbyasuncion pushed a commit to gabbyasuncion/mongo-go-driver that referenced this pull request Nov 18, 2021
@matthewdale @gabbyasuncion
GODRIVER-2156 Enable gosimple linter. (mongodb#795)
34f412f
gabbyasuncion pushed a commit to gabbyasuncion/mongo-go-driver that referenced this pull request Nov 19, 2021
@matthewdale @gabbyasuncion
GODRIVER-2156 Enable gosimple linter. (mongodb#795)
7873f60
faem pushed a commit to kubedb/mongo-go-driver that referenced this pull request Mar 17, 2022
@matthewdale
GODRIVER-2156 Enable gosimple linter. (mongodb#795)
44e80d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabbyasuncion gabbyasuncion gabbyasuncion approved these changes

@benjirewis benjirewis benjirewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewdale @benjirewis @gabbyasuncion