GODRIVER-1569 Add support for authorizedDatabases option #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
approved these changes
Apr 20, 2020
| @@ -11,6 +11,10 @@ type ListDatabasesOptions struct { | |||
| // If true, only the Name field of the returned DatabaseSpecification objects will be populated. The default value | |||
| // is false. | |||
| NameOnly *bool | |||
|
|
|||
| // If true, only the databases which the user is authorized to see will be returned. For more information about | |||
| // the behavior of this option, see https://docs.mongodb.com/manual/reference/privilege-actions/#find. | |||
There was a problem hiding this comment.
nit: add a note about the default value
There was a problem hiding this comment.
I'd intentionally left this out because the behavior is different not only between major server versions but between minor versions in the 4.0.x cycle, but reading the linked docs page again, I think it's safe to document that the default value is true, so I've added a note.
@jyemin During your review, can you comment whether or not you think this is OK to document?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.