GODRIVER-1405 Send app name on heartbeat and application connections #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The original Evergreen patch had a lot of red because the collection creation commands sent by the testing framework failed if the direct connection was not to the primary. I've updated to include an option to skip collection creation for tests that don't need it. |
iwysiu
approved these changes
Apr 16, 2020
craiggwilson
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom dialer code is from a POC for a proxy dialer I did a while back. There's probably a good way to make it resilient to errors, so I'm open to suggestions. The test also has to make a direct connection to make sure there's only one heartbeat connection created, regardless of the topology.