GODRIVER-1395 add MONGODB-AWS auth mechanism #334
Conversation
ShaneHarvey
requested review from
ShaneHarvey
and removed request for
ShaneHarvey
|
LGTM |
There was a problem hiding this comment.
This looks really good! My comments are primarily about using constants and improving the code consistency, but I didn't see any errors from a spec perspective.
Also, you'll need to add documentation for the AuthMechanism and AuthMechanismProperties fields in the options.Credential struct: https://github.com/mongodb/mongo-go-driver/blob/master/mongo/options/clientoptions.go#L80.
x/mongo/driver/auth/aws_conv.go
Outdated
| amzDateFormat = "20060102T150405Z" | ||
| awsRelativeURI = "http://169.254.170.2/" | ||
| awsEC2URI = "http://169.254.169.254/" | ||
| awsEC2Path = "latest/meta-data/iam/security-credentials/" |
There was a problem hiding this comment.
Rename awsEC2Path to awsEC2RolePath and awsEC2Token to awsEC2TokenPath.
|
I'll not gonna use AWS or AWS login. Why the existing library depends on AWS at all? |
|
Hi @cagataycali, If you have questions or would like to report bugs/improvements related to the driver, please file a ticket in our Jira project for tracking purposes. -- Divjot |
I had to run mod vendor, so the pr seems a lot larger than it is. All of the changes in the vendor directory can be ignored.