-
Notifications
You must be signed in to change notification settings - Fork 914
GODRIVER-3037 Support internal-only options. #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
// Copyright (C) MongoDB, Inc. 2025-present. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
// not use this file except in compliance with the License. You may obtain | ||
// a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
package options | ||
|
||
// Options stores internal options. | ||
type Options struct { | ||
values map[string]any | ||
} | ||
|
||
// WithValue sets an option value with the associated key. | ||
func WithValue(opts Options, key string, option any) Options { | ||
if opts.values == nil { | ||
opts.values = make(map[string]any) | ||
} | ||
opts.values[key] = option | ||
return opts | ||
} | ||
|
||
// Value returns the value associated with the options for key. | ||
func Value(opts Options, key string) any { | ||
if opts.values == nil { | ||
return nil | ||
} | ||
if val, ok := opts.values[key]; ok { | ||
return val | ||
} | ||
return nil | ||
} | ||
|
||
// Equal compares two Options instances for equality. | ||
func Equal(opts1, opts2 Options) bool { | ||
if len(opts1.values) != len(opts2.values) { | ||
return false | ||
} | ||
for key, val1 := range opts1.values { | ||
if val2, ok := opts2.values[key]; !ok || val1 != val2 { | ||
return false | ||
} | ||
} | ||
return true | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
// Copyright (C) MongoDB, Inc. 2025-present. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
// not use this file except in compliance with the License. You may obtain | ||
// a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
package xoptions | ||
|
||
import ( | ||
"fmt" | ||
|
||
"go.mongodb.org/mongo-driver/v2/mongo/options" | ||
"go.mongodb.org/mongo-driver/v2/x/mongo/driver" | ||
) | ||
|
||
// SetInternalClientOptions sets internal options for ClientOptions. | ||
// | ||
// Deprecated: This function is for internal use only. It may be changed or removed in any release. | ||
func SetInternalClientOptions(opts *options.ClientOptions, key string, option any) error { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need this to return an error? Should we just do nothing if an unsupported option is set? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I prefer to keep the return to avoid silent errors, for example, a typo in the key name. Otherwise, these errors would be difficult to find. |
||
const typeErr = "unexpected type for %s" | ||
switch key { | ||
case "crypt": | ||
c, ok := option.(driver.Crypt) | ||
if !ok { | ||
return fmt.Errorf(typeErr, key) | ||
} | ||
opts.Crypt = c | ||
case "deployment": | ||
d, ok := option.(driver.Deployment) | ||
if !ok { | ||
return fmt.Errorf(typeErr, key) | ||
} | ||
opts.Deployment = d | ||
default: | ||
return fmt.Errorf("unsupported option: %s", key) | ||
} | ||
return nil | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
// Copyright (C) MongoDB, Inc. 2025-present. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); you may | ||
// not use this file except in compliance with the License. You may obtain | ||
// a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
package xoptions | ||
|
||
import ( | ||
"testing" | ||
|
||
"go.mongodb.org/mongo-driver/v2/internal/require" | ||
"go.mongodb.org/mongo-driver/v2/mongo/options" | ||
"go.mongodb.org/mongo-driver/v2/x/mongo/driver" | ||
"go.mongodb.org/mongo-driver/v2/x/mongo/driver/drivertest" | ||
) | ||
|
||
func TestSetInternalClientOptions(t *testing.T) { | ||
t.Parallel() | ||
|
||
t.Run("set crypt", func(t *testing.T) { | ||
t.Parallel() | ||
|
||
c := driver.NewCrypt(&driver.CryptOptions{}) | ||
opts := options.Client() | ||
err := SetInternalClientOptions(opts, "crypt", c) | ||
require.NoError(t, err, "error setting crypt: %v", err) | ||
require.Equal(t, c, opts.Crypt, "expected %v, got %v", c, opts.Crypt) | ||
}) | ||
|
||
t.Run("set crypt - wrong type", func(t *testing.T) { | ||
t.Parallel() | ||
|
||
opts := options.Client() | ||
err := SetInternalClientOptions(opts, "crypt", &drivertest.MockDeployment{}) | ||
require.EqualError(t, err, "unexpected type for crypt") | ||
}) | ||
|
||
t.Run("set deployment", func(t *testing.T) { | ||
t.Parallel() | ||
|
||
d := &drivertest.MockDeployment{} | ||
opts := options.Client() | ||
err := SetInternalClientOptions(opts, "deployment", d) | ||
require.NoError(t, err, "error setting deployment: %v", err) | ||
require.Equal(t, d, opts.Deployment, "expected %v, got %v", d, opts.Deployment) | ||
}) | ||
|
||
t.Run("set deployment - wrong type", func(t *testing.T) { | ||
t.Parallel() | ||
|
||
opts := options.Client() | ||
err := SetInternalClientOptions(opts, "deployment", driver.NewCrypt(&driver.CryptOptions{})) | ||
require.EqualError(t, err, "unexpected type for deployment") | ||
}) | ||
|
||
t.Run("set unsupported option", func(t *testing.T) { | ||
t.Parallel() | ||
|
||
opts := options.Client() | ||
err := SetInternalClientOptions(opts, "unsupported", "unsupported") | ||
require.EqualError(t, err, "unsupported option: unsupported") | ||
}) | ||
} |
Uh oh!
There was an error while loading. Please reload this page.