-
Notifications
You must be signed in to change notification settings - Fork 915
GODRIVER-3357 Bump golangci-lint for 1.23 compatibility #1823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
prestonvasquez
merged 6 commits into
mongodb:master
from
prestonvasquez:bump-golangci-lint
Sep 23, 2024
Merged
GODRIVER-3357 Bump golangci-lint for 1.23 compatibility #1823
prestonvasquez
merged 6 commits into
mongodb:master
from
prestonvasquez:bump-golangci-lint
Sep 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change ReportNo changes found! |
…go-driver into bump-golangci-lint
joyjwang
previously approved these changes
Sep 20, 2024
matthewdale
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Once merged, I'll follow up with the script outlined in GODRIVER-3357. |
joyjwang
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
matthewdale
pushed a commit
to matthewdale/mongo-go-driver
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
golangci-lint
versions < 1.60.1 are not 1.23 compatible. See issue #4662 for more information.Background & Motivation
Devs should not be limited to the 1.22 minimum test version.