Skip to content

GODRIVER-3357 Bump golangci-lint for 1.23 compatibility #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

prestonvasquez
Copy link
Member

Summary

golangci-lint versions < 1.60.1 are not 1.23 compatible. See issue #4662 for more information.

Background & Motivation

Devs should not be limited to the 1.22 minimum test version.

@mongodb-drivers-pr-bot mongodb-drivers-pr-bot bot added the review-priority-low Low Priority PR for Review: within 3 business days label Sep 20, 2024
Copy link
Contributor

API Change Report

No changes found!

@prestonvasquez prestonvasquez requested review from joyjwang and blink1073 and removed request for matthewdale September 20, 2024 17:23
joyjwang
joyjwang previously approved these changes Sep 20, 2024
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@blink1073 blink1073 changed the title Bump golangci-lint for 1.23 compatibility GODRIVER-3357 Bump golangci-lint for 1.23 compatibility Sep 23, 2024
@blink1073
Copy link
Member

Once merged, I'll follow up with the script outlined in GODRIVER-3357.

Copy link
Contributor

@joyjwang joyjwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prestonvasquez prestonvasquez merged commit c6502c9 into mongodb:master Sep 23, 2024
29 of 33 checks passed
@prestonvasquez prestonvasquez deleted the bump-golangci-lint branch September 23, 2024 20:52
matthewdale pushed a commit to matthewdale/mongo-go-driver that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-priority-low Low Priority PR for Review: within 3 business days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants