GODRIVER-3324 Upgrade CI Go to 1.22 and golangci-lint to 1.59.1. #1783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mongodb-drivers-pr-bot
bot
added
dependencies
API Change ReportNo changes found! |
matthewdale
force-pushed
the
godriver3324-upgrade-go-v1
branch
from
b372d5a to
a848e39
Compare
This was referenced Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3324
Summary
log.Fataltolog.Panic.log.Fatalafter callingdeferprevents thedeferfrom running becauselog.Fatalexits the application immediately. In those cases, uselog.Panic, which has the same logging behavior but panics instead, which still allows deferred calls to execute.Background & Motivation
See previous PRs #1729 and #1730 that made the same change on the master branch.