GODRIVER-3036 Add prose test for ServerHeartbeatStartedEvent. #1534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingyang-hu
requested review from
prestonvasquez
and removed request for
a team
Contributor
API Change Report./bsonincompatible changes##NewDecoder: changed from func(./bson/bsonrw.ValueReader) *Decoder to func(./bson/bsonrw.ValueReader) (*Decoder, error) ./bson/bsonrwincompatible changesNewExtJSONValueWriter: changed from func(io.Writer, bool, bool) ValueWriter to func(io.Writer, bool, bool) (ValueWriter, error) compatible changesNewBSONDocumentReader: added |
prestonvasquez
previously approved these changes
Feb 1, 2024
Comment on lines
224
to
226
| go func() { | ||
| require.NoError(t, server.Connect(nil)) | ||
| }() |
Member
There was a problem hiding this comment.
Suggested change
| go func() { | |
| require.NoError(t, server.Connect(nil)) | |
| }() | |
| require.NoError(t, server.Connect(nil)) |
There is no need to connect asynchronously.
prestonvasquez
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3036
Summary
This RP adds a prose test to ensure that
ServerHeartbeatStartedEventis emitted before the monitoring connection is established.Background & Motivation
Heartbeat Tests: https://github.com/mongodb/specifications/tree/master/source/server-discovery-and-monitoring/tests#heartbeat-tests