Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate new ObjectID only when required #1479

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Generate new ObjectID only when required #1479

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f44da43
Generate new ObjectID only when required
adhocore Nov 24, 2023
e094bb5
Add ObjectID benchmark and NilObjectID test
adhocore Dec 9, 2023
30455c4
Update docs for ensureID to reflect new behavior
adhocore Dec 9, 2023
af7dd71
Lint fix
adhocore Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Lint fix
  • Loading branch information
@adhocore
adhocore committed Dec 12, 2023
commit af7dd71b2dc8a5eaab9c6259ecf2c30311c41370
2 changes: 1 addition & 1 deletion mongo/mongo_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ func TestEnsureID_NilObjectID(t *testing.T) {

assert.True(t, ok)
assert.NotEqual(t, primitive.NilObjectID, gotID)

want := bsoncore.NewDocumentBuilder().
AppendObjectID("_id", gotID).
AppendString("foo", "bar").
Expand Down
Loading