Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2943 Re-organize client entity expected log messages #1366

Merged
merged 12 commits into from
Dec 7, 2023
Merged

GODRIVER-2943 Re-organize client entity expected log messages #1366

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
97ce13c
GODRIVER-2943 Re-organize client entity expected log messages
prestonvasquez Aug 29, 2023
9460e67
GODRIVER-2943 Remove debugging statements
prestonvasquez Aug 29, 2023
2664591
GODRIVER-2943 Add 'Ok' to server description
prestonvasquez Aug 30, 2023
d3469ca
GODRIVER-2943 Remove standalone logs
prestonvasquez Aug 30, 2023
19e73d5
GODRIVER-2943 Add sync TODO comments
prestonvasquez Aug 30, 2023
6335644
GODRIVER-2943 Merge blocker fixes
prestonvasquez Oct 5, 2023
171895f
GODRIVER-2943 Remove Ok from server
prestonvasquez Oct 10, 2023
58cb48e
GODRIVER-2943 Fix sharded case
prestonvasquez Oct 11, 2023
ae54e2d
GODRIVER-2943 Fix race test failure
prestonvasquez Oct 11, 2023
7b63b61
GODRIVER-2943 Resolve merge conflicts
prestonvasquez Dec 4, 2023
9a2d146
Merge branch 'v1' into GODRIVER-2943
prestonvasquez Dec 5, 2023
bcf1d75
Merge branch 'v1' into GODRIVER-2943
prestonvasquez Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GODRIVER-2943 Remove Ok from server
  • Loading branch information
@prestonvasquez
prestonvasquez committed Oct 10, 2023
commit 171895f94fa0dd2f3c2229ddebf45121a4595aad
3 changes: 0 additions & 3 deletions mongo/description/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ type Server struct {
TopologyVersion *TopologyVersion
Kind ServerKind
WireVersion *VersionRange
Ok int32
}

// NewServer creates a new server description from the given hello command response.
Expand Down Expand Up @@ -230,8 +229,6 @@ func NewServer(addr address.Address, response bson.Raw) Server {
desc.LastError = errors.New("not ok")
return desc
}

desc.Ok = okay
case "passives":
var err error
desc.Passives, err = stringSliceFromRawElement(element)
Expand Down