Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence libmongocrypt build #1279

Merged
merged 4 commits into from
May 30, 2023
Merged

Conversation

kevinAlbs
Copy link
Contributor

Summary

  • Hide libmongocrypt output by default
  • Clone libmongocrypt with depth=1
  • Use "bash" in every shell.exec

Background & Motivation

Hide libmongocrypt output by default

This is intended to reduce the logs in Evergreen that are not helpful to Go driver development.

Before this change, a sample task includes 1716 lines of log output are from compiling libmongocrypt. After this change, there is 7 lines of output. The full logs of libmongocrypt compile are still printed on error to aid debugging a failed libmongocrypt build. This patch tests a broken libmongocrypt build to verify the logs are printed.

Use "bash" in every shell.exec

This is recommended in Evergreen documentation

shell: shell to use. Defaults to sh if not set. Note that this is usually bash but is dash on Debian, so it's good to explicitly pass this parameter

@kevinAlbs kevinAlbs force-pushed the silence-libmongocrypt branch from 8e68b4c to cb920ef Compare May 24, 2023 12:37
@kevinAlbs kevinAlbs marked this pull request as ready for review May 24, 2023 17:39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to revise L2473 as well.

@kevinAlbs kevinAlbs requested a review from qingyang-hu May 25, 2023 22:08
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kevinAlbs kevinAlbs merged commit 9460dba into mongodb:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants