Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2761 support Queryable Encryption v2 #1213

Merged
merged 11 commits into from
Apr 4, 2023

Conversation

kevinAlbs
Copy link
Contributor

@kevinAlbs kevinAlbs commented Mar 29, 2023

Summary

  • Resync test changes made in DRIVERS-2435
    • Remove fle2-* tests expecting the QEv1 protocol.
    • Add fle2v2-* tests expecting the QEv2 protocol.
  • Test with libmongocrypt 1.8.0-alpha0
  • Document requirement of libmongocrypt 1.8.0 for Go driver 1.12.0.
  • Skip Queryable Encryption tests on Serverless until DRIVERS-2589 is resolved.
  • Require server 7.0 to run Queryable Encryption tests.

A full patch build was run here: https://spruce.mongodb.com/version/64244a0e5623434b22490144. Test failures appear unrelated to these changes.

Background & Motivation

See DRIVERS-2435.

@kevinAlbs kevinAlbs changed the title GODRIVER-2761 update tests for Queryable Encryption v2 GODRIVER-2761 update for Queryable Encryption v2 Mar 31, 2023
@kevinAlbs kevinAlbs changed the title GODRIVER-2761 update for Queryable Encryption v2 GODRIVER-2761 support Queryable Encryption v2 Mar 31, 2023
@kevinAlbs kevinAlbs marked this pull request as ready for review March 31, 2023 13:09
@@ -2220,8 +2232,14 @@ func TestClientSideEncryptionProse(t *testing.T) {
}
})

rangeRunOpts := mtest.NewOptions().MinServerVersion("6.2").Topologies(mtest.ReplicaSet, mtest.Sharded, mtest.LoadBalanced, mtest.ShardedReplicaSet)
rangeRunOpts := mtest.NewOptions().MinServerVersion("7.0").Topologies(mtest.ReplicaSet, mtest.Sharded, mtest.LoadBalanced, mtest.ShardedReplicaSet)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: rangeRunOpts is a duplicate of autoKeyRunOpts. Is there a way to refactor this opts?

Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me with a trivial comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants