-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-2761 support Queryable Encryption v2 #1213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2023
kevinAlbs
changed the title
GODRIVER-2761 update tests for Queryable Encryption v2
GODRIVER-2761 update for Queryable Encryption v2
Mar 31, 2023
kevinAlbs
changed the title
GODRIVER-2761 update for Queryable Encryption v2
GODRIVER-2761 support Queryable Encryption v2
Mar 31, 2023
qingyang-hu
reviewed
Apr 3, 2023
@@ -2220,8 +2232,14 @@ func TestClientSideEncryptionProse(t *testing.T) { | |||
} | |||
}) | |||
|
|||
rangeRunOpts := mtest.NewOptions().MinServerVersion("6.2").Topologies(mtest.ReplicaSet, mtest.Sharded, mtest.LoadBalanced, mtest.ShardedReplicaSet) | |||
rangeRunOpts := mtest.NewOptions().MinServerVersion("7.0").Topologies(mtest.ReplicaSet, mtest.Sharded, mtest.LoadBalanced, mtest.ShardedReplicaSet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: rangeRunOpts
is a duplicate of autoKeyRunOpts
. Is there a way to refactor this opts?
qingyang-hu
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me with a trivial comment.
prestonvasquez
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fle2-*
tests expecting the QEv1 protocol.fle2v2-*
tests expecting the QEv2 protocol.A full patch build was run here: https://spruce.mongodb.com/version/64244a0e5623434b22490144. Test failures appear unrelated to these changes.
Background & Motivation
See DRIVERS-2435.