Delete unnecessary dependency for pretty printing in an example #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`%#v` is supported in go1.13. Ref: https://github.com/golang/go/blob/go1.13/src/fmt/doc.go#L18
matthewdale
approved these changes
Feb 24, 2023
There was a problem hiding this comment.
@das7pad thanks for the PR! Looks good 👍
If you want to remove the entry for github.com/kr/pretty from THIRD_PARTY_LICENSES by hand, please feel free to. Otherwise, I can regenerate the THIRD_PARTY_LICENSES to update it later.
I'll merge this once the build and test process completes successfully!
matthewdale
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
@das7pad thank you for the THIRD-PARTY-NOTICES updates! Changes and tests look good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi! I noticed an unnecessary dependency for pretty printing in an example. This PR is dropping it in favor of using plain std-lib formatting.
%#vis supported in go1.13.Ref: https://github.com/golang/go/blob/go1.13/src/fmt/doc.go#L18
I tried to update/re-generate the
THIRD-PARTY-NOTICES, but the diff contains lots of unrelated changes (on a glance, this might be a change in sorting only). I can delete the two related entries by hand too.Background & Motivation
I want to cleanup spurious items from go.mod/go.sum in my application.