Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore third-party files on adding licenses #1179

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

prestonvasquez
Copy link
Collaborator

Summary

Ignore third-party files when adding licenses to files in the Go Driver.

Background & Motivation

The etc/add-license.sh script will try to add the copyright notice to third-party imports, which is not necessary.

@prestonvasquez prestonvasquez changed the title revert extra data Ignore third-party files on adding licenses Feb 8, 2023
Copy link
Collaborator

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@benjirewis
Copy link
Contributor

BTW I have a feeling the add-license make target will still not fail in CI when changes were unexpectedly made to files. I believe it has something to do with the behavior of git diff --quiet on linux.

@prestonvasquez prestonvasquez merged commit d957e67 into mongodb:master Mar 2, 2023
@prestonvasquez prestonvasquez deleted the add-license-to-fuzz branch March 2, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants