GODRIVER-2559 Do not connect to mongocryptd if shared library is loaded #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
changed the title
matthewdale
reviewed
Oct 28, 2022
mongo/client.go
Outdated
| @@ -437,7 +437,7 @@ func (c *Client) configureAutoEncryption(clientOpts *options.ClientOptions) erro | |||
| } | |||
|
|
|||
| // If the crypt_shared library was loaded successfully, signal to the mongocryptd client creator | |||
| // that it can bypass spawning mongocryptd. | |||
| // that it can bypass spawning or connecting to mongocryptd. | |||
| cryptSharedLibAvailable := mc.CryptSharedLibVersionString() != "" | |||
| mongocryptdFLE, err := newMongocryptdClient(cryptSharedLibAvailable, clientOpts.AutoEncryptionOptions) | |||
There was a problem hiding this comment.
Is there anything in the mongocryptdClient that we need when the crypt_shared library is loaded? Can we skip creating the client completely?
E.g.
if mc.CryptSharedLibVersionString() == "" {
mongocryptdFLE, err := newMongocryptdClient(clientOpts.AutoEncryptionOptions)
if err != nil {
return err
}
c.mongocryptdFLE = mongocryptdFLE
}There was a problem hiding this comment.
I think no. Skipping creating the client seems preferable. Thank you for the suggested code. Updated.
Co-authored-by: Matt Dale <9760375+matthewdale@users.noreply.github.com>
Co-authored-by: Preston Vasquez <24281431+prestonvasquez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2559
Summary
Background & Motivation
mongocryptd and the crypt shared library share the same functionality. Creating a
mongo.Clientto mongocryptd is unnecessary if using the shared library. mongocryptd will not be used if the shared library is used.