Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /data directory to /testdata. #1061

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

matthewdale
Copy link
Collaborator

The Go test tool recommends putting test data in a "testdata" directory:

The go tool will ignore a directory named "testdata", making it available to hold ancillary data needed by the tests.

We do this elsewhere in the repository (e.g. /mongo/options/testdata), but not for the top-level test data directory /data. Move the /data directory to /testdata and update all references.

Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of mongo/text.txt?

Copy link
Contributor

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me; thanks! Do you know if the system failures in the linked patch are related?

@matthewdale
Copy link
Collaborator Author

@qingyang-hu good find! That mongo/text.txt file was an accidental inclusion. I've removed it.

@benjirewis I don't believe the system failures are related to these changes. However, I rebased on the master branch to make sure this branch has all the latest test fixes. If there are more unexplained test failures, I'll investigate them.

Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It looks great!

@matthewdale matthewdale merged commit d2ec1fc into mongodb:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants