GODRIVER-2464 Add delay in RTT monitor test so Windows can measure a non-zero latency. #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non-zero latency.
benjirewis
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
LGTM. The remaining Windows failures seem to be due to GODRIVER-2483 (flaky failures of TestClient/RTT90_used_to_prevent_sending_requests on Windows probably caused by a very similar issue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
TestRTTMonitor/stuck_operations_time_outtest added in #994 fails frequently on Windows tasks because Go running on some versions of Windows can't measure very short periods of time (<1ms) reliably (see test failure example here and related Go issue here).Add a 10ms delay in the
TestRTTMonitor/stuck_operations_time_outtest "hello" responder so that Windows can successfully measure a non-zero round-trip latency.