GODRIVER-2446 Update Fixable Dep Vulnerabilities, Identify Un-Fixable Dep Vulnerabilities #1005
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,11 @@ retract ( | |
| [v1.6.0, v1.6.1] // Contains data race bug in background connection establishment. | ||
| ) | ||
|
|
||
| // gopkg.in/yaml.v3@v3.0.0-20200313102051-9f266ea9e77c introduced through github.com/stretchr/testify@v1.6.1 are | ||
| // vulnerable to Denial of Service (DoS) via the Unmarshal function, which causes the program to crash when attempting | ||
| // to deserialize invalid input. https://www.cve.org/CVERecord?id=CVE-2022-28948 | ||
| replace gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c => gopkg.in/yaml.v3 v3.0.1 | ||
|
There was a problem hiding this comment. @matthewdale as you've noted, updating to a version of testify that resolves CVE-2022-28948 is not something we can do without breaking support for Go v10. Using replace updates the vulnerable yaml.v3 version to 3.0.1, which removes it from go.sum. However, the testify package still points to There was a problem hiding this comment. I think that's fine. The only version of gopkg.in/yaml.v3 in |
||
|
|
||
| require ( | ||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/go-stack/stack v1.8.0 | ||
|
|
@@ -18,15 +23,11 @@ require ( | |
| github.com/pkg/errors v0.9.1 | ||
| github.com/stretchr/testify v1.6.1 | ||
| github.com/tidwall/pretty v1.0.0 | ||
| github.com/xdg-go/scram v1.1.1 | ||
| github.com/xdg-go/stringprep v1.0.3 | ||
| github.com/youmark/pkcs8 v0.0.0-20181117223130-1be2e3e5546d | ||
| golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d | ||
| golang.org/x/sync v0.0.0-20210220032951-036812b2e83c | ||
| gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.